TOR-2198 Uusi api hakemuspalveluille #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hruoho
force-pushed
the
TOR-2198-uusi-hakemuspalvelu-api
branch
3 times, most recently
from
4b4b2c9
to
e289ae9
Compare
hruoho
commented
Jul 12, 2024
Comment on lines
21
to
19
| post("/hetu") { | ||
| withJsonBody { json => | ||
| renderEither(extractAndValidateHetu(json).flatMap(application.hakemuspalveluService.findOppijaByHetu)) | ||
| }() | ||
| } |
There was a problem hiding this comment.
Tarvitaanko ollenkaan?
hruoho
commented
Jul 12, 2024
| try { | ||
| val opiskeluoikeudet: Seq[schema.YlioppilastutkinnonOpiskeluoikeus] = | ||
| if (useDownloadedYtr) { | ||
| fetchDownloadedYtrOpiskeluoikeudet(masterHenkilö) |
There was a problem hiding this comment.
Pura rajapintahaku funktion sisältä eksplisiittisemmin tähän
hruoho
commented
Jul 12, 2024
| private def josKKTutkintoNiinVahvistettu(s: HakemuspalveluSuoritus): Boolean = { | ||
| s match { | ||
| case s: HakemuspalveluKorkeakoulututkinnonSuoritus | ||
| => s.vahvistus.isDefined |
a544jh
approved these changes
Jul 12, 2024
hruoho
force-pushed
the
TOR-2198-uusi-hakemuspalvelu-api
branch
from
56757b2
to
0a35361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.