-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected deletion of the keyPrefix option #2083
Labels
Comments
nekocode
added a commit
to nekocode/bull
that referenced
this issue
Jul 1, 2021
nekocode
added a commit
to nekocode/bull
that referenced
this issue
Jul 1, 2021
nekocode
added a commit
to nekocode/bull
that referenced
this issue
Jul 1, 2021
manast
pushed a commit
that referenced
this issue
Jul 1, 2021
github-actions bot
pushed a commit
that referenced
this issue
Jul 1, 2021
## [3.22.10](v3.22.9...v3.22.10) (2021-07-01) ### Bug Fixes * deep clone options ([#2083](#2083)) ([1e00a90](1e00a90))
🎉 This issue has been resolved in version 3.22.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In latest code, the instantiation of queue will deleted
keyPrefix
property of the options object which we passed to the second function parameter:It causes that we will loss the
keyPrefix
if we use one options instance to initialize multiple queues.I think we should use a deep cloned options object to make sure the passed one will not be changed.
Minimal, Working Test code to reproduce the issue.
I wrote a test to reproduce the issue:
nekocode@06feb31
Bull version
3.22.9 (latest)
The text was updated successfully, but these errors were encountered: