(WIP) Add in Type-Safety #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
commented
Nov 12, 2023
| @@ -1,10 +1,7 @@ | |||
| import copy | |||
| import os | |||
There was a problem hiding this comment.
Ruff got ran here.
max-muoto
commented
Nov 12, 2023
| @@ -62,6 +58,8 @@ python = ">=3.8.0,<4" | |||
| django = ">=3" | |||
|
|
|||
| [tool.poetry.dev-dependencies] | |||
| pyright = "^1.1.335" | |||
There was a problem hiding this comment.
Can pin these if you like.
max-muoto
commented
Nov 12, 2023
| @@ -276,10 +307,10 @@ def schema(*schemas: str, databases: Union[List[str], None] = None): | |||
| yield | |||
|
|
|||
|
|
|||
| schema.session = _schema_session | |||
| schema.session = _schema_session # type: ignore | |||
There was a problem hiding this comment.
Fix here is making these class-based context managers, can do so in a follow-up PR. Just didn't want to refactor them here.
max-muoto
commented
Nov 12, 2023
| from pgtrigger import utils | ||
|
|
||
| _unset = object() | ||
|
|
||
| Unset = NewType("Unset", object) |
There was a problem hiding this comment.
NewType helps prevents bugs by accepting object. Accepting object as a type-hint significantly reduces the type-safety of a method, so this enforces that we explicitly are setting it our unset object. Before having this I had actually incorrectly typed some things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.