Refactored bucket.gd #681
Merged
Refactored bucket.gd #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated out the larger functions to ease readability and possible future improvements.
src/Tools/Bucket.gd
Outdated
| while not done: | ||
| done = true | ||
| var max_index = _allegro_flood_segments.size() | ||
| #print(max_index) |
There was a problem hiding this comment.
You forgot a commented print here :)
There was a problem hiding this comment.
Who? Me? Impossible!
Now, late-night-commit-me, you shouldn't trust that guy's code...
(thanks for spotting this)
|
Just for context, the point of the refactor in this PR is to do this: |
OverloadedOrama
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out the larger functions to ease readability and possible future improvements.