Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crop Tool #830

Merged
merged 24 commits into from Mar 16, 2023
Merged

Crop Tool #830

merged 24 commits into from Mar 16, 2023

Conversation

mrtripie
Copy link
Contributor

@mrtripie mrtripie commented Mar 9, 2023

No description provided.

MrTriPie added 23 commits March 9, 2023 09:59
Added intial crop tool
84eb41b
[skip ci] Removed unneeeded LINE_WIDTH constant from CropRect
3b11efc
Added DimensionsLabel
37b5483
Cleaned up CropRect._draw
1892aed
Hide the CropRect after switching to a different tool
4765a02
Sets the crop values to the entire canvas size on setup
1c5aab5
[skip ci] Added crop tool tooltip
aef3b94
Made Crop tools synced with eachother by placing the crop settings on…
d05370f 
… CropRect
Added new modes, refactored, added rule of thirds lines and darkened …
f15e79c 
…background
[skip ci] reset optimization
0c05a1f
Renames
dc7a422
[skip ci] Tweaked the darkened background
0489fdf
Fixed bug with top/bottom/left/right sliders after rect refactor
ec097dd
Changing width/height on locked aspect ratio bug
0f5897b
Aspect ratio sliders rounding/setting a min of 1 px height/width
e62fa01
Fixed bugs with drawing the crop rect, especially with locked aspect …
f55196d 
…ratio
Save the mode to config_cache
93da955
Added size lock and renamed mode
b5b6dda
Added tooltip for size lock. Not sure if I did the translation file r…
5842051 
…ight
removed signal that wasn't used
45bcf3e
Formatting
1acb255
Removed old TODO comment from one of my previous PRs that isn't true …
020f350 
…anymore
Fixed definition order for linter
df985fc
@mrtripie mrtripie marked this pull request as ready for review March 13, 2023 02:46
OverloadedOrama
OverloadedOrama approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very nice addition, thank you!

@OverloadedOrama OverloadedOrama merged commit 0ad8681 into Orama-Interactive:master Mar 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrtripie @OverloadedOrama