Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mirrored drawing #843

Merged
merged 2 commits into from Apr 14, 2023
Merged

Conversation

ChrisTs8920
Copy link
Contributor

@ChrisTs8920 ChrisTs8920 commented Apr 9, 2023

Fixes #842.

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I don't think this is the correct approach, as this offsets the mirrored pixels by one pixel, which makes the symmetry look wrong. What issue #842 is referring to is the default placement of the symmetry axes. I think simply removing "+ 0.5" from lines 73, 74, 79 and 80 in Project.gd should be a better solution.

@ChrisTs8920
Copy link
Contributor Author

ChrisTs8920 commented Apr 13, 2023

Thank you for the feedback! Yes, my solution was not really correct. Upon testing your approach i noticed that it works only if i enable the symmetry guides at least once. If not issue #842 still persists. As a result, I recommend retaining lines 73, 74, 79 and 80 as they are, and adding "- 1" to lines 68 and 69 in Project.gd instead. I believe this approach addresses the issue more accurately, and if not I'm happy to hear your suggestion!

@OverloadedOrama
Copy link
Member

The approach you recommended seems to be working fine! I don't see any problems with it. Feel free to update the PR :)

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OverloadedOrama OverloadedOrama merged commit db29ec9 into Orama-Interactive:master Apr 14, 2023
@ChrisTs8920 ChrisTs8920 deleted the bug branch April 14, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mirrored drawing line(s) is not centered by default
2 participants