Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop delay-cli to avoid CVE-2021-33623 and use sirv-cli #1005

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Drop delay-cli to avoid CVE-2021-33623 and use sirv-cli #1005

merged 1 commit into from
Jan 28, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 29, 2021 •
edited

Drop delay-cli to avoid CVE-2021-33623 vulnerability.

Note: could be fixed by sindresorhus/delay-cli#6 as well.

The use of sirv-cli comes from the WIP Bootstrap branch https://github.com/twbs/bootstrap/blob/main-xmr-pa11y-ci.

@julien-deramond julien-deramond added dependencies Pull requests that update a dependency file security labels Dec 29, 2021
@julien-deramond julien-deramond marked this pull request as draft December 29, 2021 07:13
@julien-deramond julien-deramond marked this pull request as ready for review December 29, 2021 07:28
@julien-deramond julien-deramond changed the title chore(dev-deps): drop delay-cli Drop delay-cli to avoid CVE-2021-33623 and use sirv-cli Dec 29, 2021
@julien-deramond julien-deramond changed the title Drop delay-cli to avoid CVE-2021-33623 and use sirv-cli Drop delay-cli to avoid CVE-2021-33623 and use sirv-cli Dec 29, 2021
@julien-deramond julien-deramond marked this pull request as draft January 4, 2022 11:27
@julien-deramond julien-deramond self-assigned this Jan 4, 2022
@julien-deramond
Copy link
Member Author

Put it back in Draft mode cause I gotta check again if replacing npm run dist + npm run release-sri + npm run docs-build with npm run docs does the job.

@julien-deramond julien-deramond force-pushed the main-jd-drop-delay-cli-dependency branch from ed8c87b to 42fb1cb Compare January 11, 2022 12:26
@julien-deramond
Copy link
Member Author

julien-deramond commented Jan 11, 2022 •
edited

  1. Created 3db3297 that should be caught by pa11y-ci.
    As you mentioned @Lausselloic, it is not caught by pa11y-ci because the CSS is not regenerated (see https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/runs/4775193184?check_suite_focus=true).
  2. Put back the previous configuration via 005b7b9: pa11y-ci catches the new error introduced in the Sass file. So, good catch :) I'll let the previous config.

I tested it locally as well. Results are confirmed.

(Note: I don't resolve the conflicts before your review in order to keep the results and commits references in place)

@julien-deramond julien-deramond marked this pull request as ready for review January 11, 2022 12:47
@julien-deramond julien-deramond force-pushed the main-jd-drop-delay-cli-dependency branch from 34d1b78 to 65d6990 Compare January 28, 2022 09:02
@julien-deramond julien-deramond merged commit 88294fe into main Jan 28, 2022
@julien-deramond julien-deramond deleted the main-jd-drop-delay-cli-dependency branch January 28, 2022 09:22
@julien-deramond julien-deramond mentioned this pull request Jan 28, 2022
Closed
julien-deramond added a commit that referenced this pull request Jan 28, 2022
@julien-deramond
fix(#1005): restore line heights var values by fixing calc(divide()) …
8d4701e 
…operations
julien-deramond added a commit that referenced this pull request Jan 28, 2022
@julien-deramond
fix(#1005): restore line heights var values by fixing calc(divide())
122d998
julien-deramond added a commit that referenced this pull request Feb 1, 2022
@julien-deramond
fix(#1005): restore line heights var values by fixing calc(divide()) (
e37940c 
#1070)
Nurovek pushed a commit that referenced this pull request Feb 11, 2022
feat(headers): Global Headers components (squashed)
f48b703 
author LE DIOURON Kevin <kevin.lediouron.ext@orange.com> 1626946275 +0200
committer LE DIOURON Kevin <kevin.lediouron.ext@orange.com> 1644573012 +0100

parent c27e1e1
author LE DIOURON Kevin <kevin.lediouron.ext@orange.com> 1626946275 +0200
committer LE DIOURON Kevin <kevin.lediouron.ext@orange.com> 1644572436 +0100

feat(navbars): add Global Headers components

chore(review): fix bad URLs, JS formatting and SCSS errors

chore(review): remove .global class reference in migration page

fix(misc): WIP reviews from Louis-Maxime

fix(misc): WIP reviews from Louis-Maxime

fix(logo): correct scss for imgs & svgs

fix(headers): align on the bottom of the text

Fix(Examples) : in large viewport, orange bar below active item located to high + extra border in Exampes/NavBar (OBS)

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>

Fix(Examples) : in small viewport, orange bar below active item located to high

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>

Fix(global header) : add collapse for viewport 768-1023px

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>

fix(navbar): spacing between last-child

fix(minimized): [wip] spacing between icons, remove important later

fix(style): [wip] clean navbar css

review: add navbar static and fixed examples

fix(scss) : [WIP] clean css

fix(scss): [WIP] clean orange-navbar

fix(scss): change comment to disable important check

Fix(orange-navbar): height of global header and all its variants have a correct height in small and larger breakpoints

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>

Fix(orange-navbar): height of global header and all its variants have a correct height in small and larger breakpoints

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>

fix(html): Revamp of the html for examples. Some checks to do (height of elements, ...)

fix(html): shortcode template for orange-navbar examples

fix(menus): Ellipsis for when a text is wider than 8rem

Fix for responsive part to fit to others atm

Amend the large viewport container misalignment

Sticky header example (#1089)

* Add(Examples): add a sticky global header + supra bar example

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>

* fix(misc): Shenanigans to fix css-side

* Backport some changes

* Minor fixes

* fix(fixed): Have the supra + global properly fixed and sticky at the top. Todo : top 40px (into rem)

Co-authored-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Co-authored-by: LE DIOURON Kevin <kevin.lediouron.ext@orange.com>

fix(sticky): Allocate some height to display both supra + global navbars with stickiness

fix(nav-link): Show anew the active selector

fix(nav-link): revert to the "original" padding as in the main branch

Can't even remember why the padding in line 203 has been changed...

Icons spacing + icons alignment

fix(supra): Change the padding-bottom variable to fix the missing pixel

Revert navbar-fixed and navbar-static examples

fix(sticky): Fix the example to have both navbars into the header markup

Add fake navbar-sticky images to fix 'npm run docs'

Minimized fixed + burger

Fix example

fix(sticky): remove grey container and banner role

fix(overflow): Revert the overflowing of content since it doesn't suit us atm

Small changes in md- breakpoints

fix(breakpoint): menu for doc navbar compatible with md breakpoint

md breakpoint

.

Minor fix on supra + .active

fix(docs): Use shortcodes for examples, add a condition to hide basket icon. TODO (or not ?): fix wrapping in docs

Minor fixes

chore(merge main) patched commit → c1222d6 (#1063)

feat(spinners): reintegrate growing spinners from v4 (#1041)

Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>

chore(dev-deps): drop `delay-cli` and add `sirv-cli` (#1005)

chore(merge main) patched commit → 76802e2 (#1071)

fix(#1072): vertically align labels for switches (#1081)

fix(forms): black outline for focused switches (#1082)

chore(merge main) patched commit → dc09509 (#1080)

fix(accordion): remove active text color on focus (#1087)

chore(merge main) patched commit → a805330 (#1090)

chore(merge main) patched commit → 8f11c52 (#1092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lausselloic Lausselloic Awaiting requested review from Lausselloic

Assignees

@julien-deramond julien-deramond

Labels
dependencies Pull requests that update a dependency file security v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julien-deramond