Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): replace '..' by '…' in the documentation title #1213

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 20, 2022

Before this modification, screen reader said "and ergonomic components library dot dot".
With this modification, screen reader will say ""and ergonomic components library".

/CC @Aniort ;) Thanks again for your presentation about screen readers. I tried it with Orca on Ubuntu.

@julien-deramond julien-deramond added v5 accessibility docs Improvements or additions to documentation labels Apr 20, 2022
@julien-deramond julien-deramond marked this pull request as ready for review April 20, 2022 12:24
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a bit complicated to review but I can't see no regression 🚀

@julien-deramond julien-deramond merged commit f82282d into main Apr 22, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-description branch April 22, 2022 05:51
@julien-deramond julien-deramond mentioned this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants