-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): hide input control text under valid icon #1306
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need the changes suggested by @louismaximepiton in his comment.
Or at least we should create a distinct issue for the problem raised by LM.
ac4259b
to
a2456b4
Compare
@MewenLeHo or @louismaximepiton Please check this new version including 87892ff which should fix |
LGTM 👌 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #1305
This PR is a proposal to fix #1305 by:
padding-right
rule than in BootstrapDear reviewer please check all possible cases in forms when inputs are valid.
Live previews