Valid icon on select #1371
Valid icon on select #1371
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
LGTM! @MewenLeHo I let you double-check the latest modifications before merging it.
@louismaximepiton Could you create an issue to try to reset those files from Bootstrap and apply our modifications on top of it. On top of it, it will help with the "Boosted mod" comments that are off in those files.
Looks good but I found two possible problems : In responsive, the valid icon goes behind the text on small screen: And in desktop, if the text written in the textarea is long enough to have a scroll bar then the valid icon goes partially behind it (may depend of the browser): |
Resolved by #1306.
Bootstrap seems to have the same issue 🤷 |
|
Kudos, SonarCloud Quality Gate passed!
|
Fixes #1342
Actually wondering if we need to continue upgrade this file or reset the file to the Bootstrap one and apply changes to it since our mindset changed on validation icons.
Apply Bs solution on valid state only. I think that textareas already have a valid state.