Correction suite retours sur le MVP en version 5.0.0-alpha.4 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThomasDgop
commented
Apr 18, 2024
•
ThomasDgop
commented
- Ajout des réglages manquants inactifs
- Prise en compte d'une catégorie ouverte par défaut pour chaque mode
- Correction libellé "Guide de lecture" qui doit être "Règle de lecture"
ffoodd
approved these changes
Apr 22, 2024
| @@ -20,12 +20,20 @@ Object.freeze(stringServiceInstance); | |||
| // @note We don't freeze these services to be able to redefine certain variables | |||
| const routeServiceInstance = new RouteService(); | |||
There was a problem hiding this comment.
Faudrait qu’on trouve un moyen de factoriser ça, mais je sais pas trop comment. C’est quand même une sacrée tartine, là !
Pas d’urgence tant que ça marche, mais si quelqu’un a une idée, ça vaudrait le coup d’essayer :)
| case 'visionPlus': | ||
| this.querySelector('app-layout').setAttribute('data-is-main-category', 'true'); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
C’est le même quer facilePlus, donc on pourrait joindre les deux :
Suggested change
| default: | |
| case 'facilePlus': | |
| default: |
En virant le premier cas, évidemment :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.