This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
cep: clean subscription #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- send unsubscription to the originator when the subscriptionId is invalid
- move the unsubscribe code from NgsiController to SubscriptionManager
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #40
The CEP subscribes to the Broker entities configured in the configuration file.
The CEP does not persist subscriptions.
If the CEP is restarted (after a crash or a user stop), the CEP done again the subscriptions.
The broker sends two notifications (during 1H of subscription time), and one of them is invalid and therefore rejected.
It is proposed to reject the notification but also to send the Broker an unregistration so the Broker could clean the subscription. The Broker will send a single notification.
The unsubscribe will be made only if the subscription is invalid and if the susbcription third mechanism is not engaged.