Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/7747/recaptcha #7748

Closed
wants to merge 3 commits into from
Closed

Issues/7747/recaptcha #7748

wants to merge 3 commits into from

Conversation

sfmskywalker
Copy link
Member

Fixes issue #7747 where the UpdateEditor of all content parts on the newed-up Comment content item is invoked twice, causing an issue with the ReCaptchaPartDriver.

Also corrected a small typo.

See issue #7747.

Sipke Schoorstra added 2 commits June 25, 2017 16:58
The second call seems to be unnecessary, and cause an issue with the ReCaptchaPartDriver (submitting the solved captcha twice to Google).

Fixes #7747
The call to Create before UpdateEditor is important.
See comments on #7747 and #6733
@sfmskywalker
Copy link
Member Author

I updated the PR by moving the call to ContentManager.Create up so that it executes before the call to ContentManager.UpdateEditor to prevent the issue with Audit Trail as described in #6733.

@sebastienros
Copy link
Member

As commented on the issue, we moved Create down on purpose, otherwise it would create transaction log, even on spam.

@BenedekFarkas
Copy link
Member

Closing this as the origin issue is already closed and I can't repro the problem on either of 1.10.x and dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants