Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Castle.Core could be replaced by source code generation #15670

Open
sebastienros opened this issue Apr 5, 2024 · 0 comments
Open

Castle.Core could be replaced by source code generation #15670

sebastienros opened this issue Apr 5, 2024 · 0 comments
Labels
enhancement perf
Milestone
2.x

Comments

@sebastienros
Copy link
Member

Intercept any call to CreateShape taking a class which does not implement IShape and generate a custom implementation instead with the ShapeViewModel mixin like Castle is currently used. Then the CreateShape code will lookup for the actual type to use in a dictionary that is populated from source code generation. Activator.CreateInstance will be much faster.
@hishamco hishamco changed the title Castle.Core culd be replaced by source code generation Castle.Core could be replaced by source code generation Apr 5, 2024
@sebastienros sebastienros added this to the 1.x milestone Apr 11, 2024
@Piedone Piedone added the perf label Apr 24, 2024
This was referenced May 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement perf
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
2 participants
@sebastienros @Piedone