Copy translation message logs twice

[hishamco]

I noticed in the last few releases that a translation message logged twice while building a project

[Piedone]

Please add repro steps and details, as asked in the template.

[hishamco]

1. Open your favorite command line
2. Locate OC repo
3. Run dotnet build
4. You will see "Copying translations files" twice per project

[hyzx86]

Dears , Where does the PackageTranslationFiles in the OrchardCore.Application.Cms.Core.Targets.targets file come from?

  <Target
    Name="CopyPackageTranslationFiles"
    AfterTargets="Build">
    <Message Text="Copying translation files: $(MSBuildProjectName)" Importance="high" />
    <Copy
      SourceFiles="%(PackageTranslationFiles.FullPath)"
      DestinationFolder="Localization\%(RecursiveDir)"
      Condition="'@(PackageTranslationFiles)' != ''"
      SkipUnchangedFiles="true"
      OverwriteReadOnlyFiles="false" />
  </Target>

[hyzx86]

@hishamco I was trying to locate the problem mentioned in #16153.
I searched for the whole solution, looked for Copying translation files and found this.

[hishamco]

Dears , Where does the PackageTranslationFiles in the OrchardCore.Application.Cms.Core.Targets.targets file come from?

I don't know :) that's why I prefer to use MSBuild programmatically :)

Related to #12364

[sebastienros]

Before net8.0 we were targeting 6 and 7. Because the build is done in parallel, some files were locked during the copy process. We tried to copy the files once even with two targets, but the way the Targets in MSBUILD work when you have multiple tfms doesn't allow for that. So we decided to copy twice at a point where it's not concurrent anymore. Though with a single TFM (net8.0) I am not sure it should still happen.

[sebastienros]

@hishamco can you try with a previous version, and the net8 SDK only (no net9). Ideally at a commit after #14732, I would expect to be copied once for a single TFM.

[hishamco]

I expect the issue is related to TFMs, but while we set it to .net8.0 I thought that might be another reason for that

[sebastienros]

I have no idea what the new screenshot is trying to demonstrate, and why it is different from the first screenshot.

[sebastienros]

Or is the new screenshot from 1.8.3 as I suggested to try?

[hishamco]

Sorry, the new screenshot shows that when I run the build before your linked PR, everything is fine, and copying translations logs once

[sebastienros]

The PR is fine, however it works after the PR is the intended behavior (maybe not the optimal but one that doesn't crash randomly). Maybe watching the meeting that happened right after the PR would give some explanations what to expect.

[hishamco]

I will check then see how it goes

[github-actions]

It seems that this issue didn't really move for quite a while despite us asking the author for further feedback. Is this something you'd like to revisit any time soon or should we close? Please reply.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.