/Localization/[CultureName]/[ModuleId].po PO file location doesn't work

[hyzx86]

Describe the bug

To Reproduce

Hi all, I've found that this rule mentioned in this document https://docs.orchardcore.net/en/latest/reference/modules/Localize/ doesn't seem to work
/Localization/[CultureName]/[ModuleId].po
This is a module based on OC 1.8.3

But when I use Localisation/zh-CN.po it works fine

[hishamco]

Seems you started a PR for this, if you are interested it's in your plate otherwise I will create another one

[hyzx86]

Seems you started a PR for this, if you are interested it's in your plate otherwise I will create another one

I am not familiar with this aspect.

[Piedone]

Shouldn't these locations rather work, @hishamco?

[hishamco]

They should, but we need to ensure the case that Tony reported still worked as expected, @hyzx86 I suggest creating a minimal repo, and then we can check.

[hyzx86]

They should, but we need to ensure the case that Tony reported still worked as expected, @hyzx86 I suggest creating a minimal repo, and then we can check

I think that test item should be included in the repository, along with automated tests to ensure the stability of the functionality

[hishamco]

What I'm asking for is a repo to ensure that there's a bug, but not miss configuration by you :)

[sebastienros]

The code that loads these files is in ModularPoFileLocationProvider. A breakpoint should help understand why the file is not loaded.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

[JulioAmestica]

the problem could be the ZH-CN language is not present in DefaultPluralRuleProvider. question, why are the languages hard coded??
By the way (the iso 639-1 defines languages codes)[https://www.andiamo.co.uk/resources/iso-language-codes/]

[hishamco]

This should handle Chinese cultures

OrchardCore/src/OrchardCore/OrchardCore.Localization.Core/DefaultPluralRuleProvider.cs

Lines 61 to 73 in ba5e8c0

	/// <example>zh-Hans-CN -> zh-Hans -> zh.</example>
	private static CultureInfo GetBaseCulture(CultureInfo culture)
	{
	var returnCulture = culture;
	while (returnCulture.Parent.Name != "") // Stop at Invariant culture
	{
	returnCulture = returnCulture.Parent;
	}
	return returnCulture;
	}
	}

[hishamco]

@hyzx86 please is this still happening with you

[hyzx86]

the problem could be the ZH-CN language is not present in DefaultPluralRuleProvider. question, why are the languages hard coded??

Like Hisham mentioned code, because there's also a concept of hierarchy here

@hishamco It may be necessary to add some unit tests to ensure that zh-CN is recognised as zh.

[hishamco]

OrchardCore/test/OrchardCore.Tests/Localization/DefaultPluralRuleProviderTests.cs

Lines 7 to 27 in 2772ac6

	[Theory]
	[InlineData("en-US", "en")]
	[InlineData("zh-TW", "zh")]
	[InlineData("zh-HanT-TW", "zh")]
	[InlineData("zh-CN", "zh")]
	[InlineData("zh-Hans-CN", "zh")]
	[InlineData("zh-Hans", "zh")]
	[InlineData("zh-Hant", "zh")]
	public void TryGetRuleShouldReturnRuleForTopCulture(string culture, string expected)
	{
	var expectedCulture = CultureInfo.GetCultureInfo(expected);
	var testCulture = CultureInfo.GetCultureInfo(culture);
	var pluralProvider = new DefaultPluralRuleProvider();
	pluralProvider.TryGetRule(expectedCulture, out var expectedPlural);
	pluralProvider.TryGetRule(testCulture, out var testPlural);
	Assert.NotNull(expectedPlural);
	Assert.NotNull(testPlural);
	Assert.Same(expectedPlural, testPlural);
	}