Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor SDK tooling #1614

Closed
sebastienros opened this issue Mar 15, 2018 · 4 comments
Closed

Razor SDK tooling #1614

sebastienros opened this issue Mar 15, 2018 · 4 comments
Assignees
Milestone

Comments

@sebastienros
Copy link
Member

We can force Web sdk by setting the OutputType explicitly:

<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <OutputType>Library</OutputType>
  </PropertyGroup>

Or use Sdk="Microsoft.NET.Sdk.Razor" directly.

@jtkech
Copy link
Member

jtkech commented Jun 15, 2018

  • So, for our applications we use .NET.Sdk.Web.

  • At one point for our modules we did the same to have razor intellisense but with <OutputType>Library. But now we use the new .NET.Sdk.Razor so that's ok.

  • The exceptions are the modules which don't have and will never have razor views. These ones use NET.Sdk as all other core libraries.

  • So, all is ok for me. The only thing is that we were using netcoreapp2.0 in the testing modules in place of netstandard2.0. I will commit an update for this.

@sebastienros
Copy link
Member Author

Tests can be netcoreapp2.1 actually. Look at the MVC repos for instance.

@jtkech
Copy link
Member

jtkech commented Jun 15, 2018

OC.Tests is already netcoreapp2.1, i was talking about the referenced testing modules under the OrchardCore.Tests.Modules folder which should use netstandard*.* in place of netcoreapp*.*.

@jtkech
Copy link
Member

jtkech commented Jun 15, 2018

@sebastienros i think we can close this one.

Note: All our app are already using netcoreapp2.1. When i talked about netstandard2.0, this is what we are using for all our libraries, including some fake modules referenced by the test application.

I did some updates here #1973.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants