Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Liquid Tag for Validations, Notifications #2740

Closed
Skrypt opened this issue Nov 26, 2018 · 5 comments · Fixed by #5099
Closed

Create Liquid Tag for Validations, Notifications #2740

Skrypt opened this issue Nov 26, 2018 · 5 comments · Fixed by #5099

Comments

@Skrypt
Copy link
Contributor

Skrypt commented Nov 26, 2018

Right now, when we are using Workflows with custom forms made in a Liquid template we can't use the Model Validation and ValidationSummary to display errors. Same probably goes with Notifications which currently are not displaying.

related to : #2241

@sfmskywalker

@Skrypt Skrypt changed the title Create Liquid Tag for Validations Create Liquid Tag for Validations, Notifications Nov 26, 2018
@jtkech
Copy link
Member

jtkech commented Nov 27, 2018

As a side note, if a tag has a razor implementation, normally we can use it through liquid. If the names are registered, 2 names if the tag can be used as a simple tag or with content (as a block), we can use e.g

{% script attr_name: ... %}` or `{% scriptblock attr_name: ... %}...{% endscriptblock %}

If the names are not registered, the above would be.

{% helper "script", attr_name: ... %}` or `{% block "script", attr_name: ... %}...{% endblock %}

@sebastienros
Copy link
Member

I can see the validation summary in the Coming Soon theme, how does it work then?

@agriffard
Copy link
Member

#2241

@sebastienros
Copy link
Member

Got it.

@ns8482e
Copy link
Contributor

ns8482e commented Feb 23, 2020

Fixed by #5099

@sebastienros sebastienros modified the milestones: 1.0, 1.1 Apr 2, 2020
@sebastienros sebastienros modified the milestones: 1.1, 1.0 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants