Added support for DictionaryAttributePrefix and ModelExplorer property in liquid

[ns8482e]

as per comments on thread
#5094 (comment)

Now, in liquid, defining following is possible,

{% block "form", action:"Edit", route-contentitemid: contentItem.ContentItemId, route-returnUrl:Request.Query["ReturnUrl"],  method:"post", enctype:"multipart/form-data" %}

{%endblock%}

And

{% form action:"Edit", route-contentitemid: contentItem.ContentItemId, route-returnUrl:Request.Query["ReturnUrl"],  method:"post", enctype:"multipart/form-data" %}

{%endform%}

Also Fixes #4426
Fixes #2740
/cc @jtkech

[jtkech]

Looks good to me but i would need more time, i will review it asap.

There is another PR #4933 i'm working on and where i tried to improve the tag helper setters, see my comment. It is not incompatible with what you did here, but maybe better to wait for this PR in case it will be merged soon, then merge dev in your branch, then i will take the time to review this PR with you.

[ns8482e]

Added Support for ModelExplorer property, i.e now properties with asp-* having ModelExplorer datatype can be used in liquid. May fix #4426 and #2740

{% helper "label", for: "XXX"%}
{% helper "input", for: "XXX" %}
{% helper "span", validation_for:"XXX" %}

[jtkech]

@ns8482e just did a little review only about formatting ;)

I assume you tried it, does it work as expected?

[ns8482e]

@jtkech yes, It works - However I'll add some sample in demo module and update the documentation too.

[ns8482e]

@jtkech Added CRUD sample that uses liquid template in OrchardCore.Demo

[jtkech]

@ns8482e okay cool ;)

I will take a look tomorrow

[ns8482e]

@jtkech @agriffard @Skrypt Updated document for liquid

[ns8482e]

@ns8482e

I did a review

Could you merge the last dev in your branch and then redo some tests as we have also updated LiquidTagHelperActivator through another PR that has been merged.

Then i will approve this PR

Works - No error

[jtkech]

@ns8482e

I'm working on it and i did some updates that i will commit tomorrow as i have to use the web interface file by file (would be good to add my github user to your repo if not already done).

Here some comments on the main changes

• When storing the TodoModel : ShapeViewModel you are saving in the database all the shape properties, so i separated things with a TodoModel and a TodoViewModel .

• For the dictionary names and keys i don't use anymore the ToPascal conversions so i reverted the change in the related extension, and now we only check for a last underscore. So it is now as other liquid attributes that are intended to use underscores e.g route_returnurl.

• So now we call LastIndexOf('_') once in place of LastIndexOfAny() 4 times without having to create a new char[] { '-', '_' } (that could have been a static field).

I will commit them tomorrow so that you will be able to see them more in details and do a review.

[ns8482e]

@jtkech you removed LastIndexOfAny so I guess route-todoid will not longer work as now it’s only looking for _ so route_todoid is only valid.

You may need to update docs for the same

[jtkech]

@ns8482e

Yes for perf reasons and it simplified the code, i already updated the doc accordingly e.g to use route_returnurl, and i did again all the tests.

[jtkech]

Forgot to say that i changed the Id property to a TodoId property because Id is a special property that is checked on yessql side and that somewhere may be related to the Id column.

Also having an identifier relying on the position of the list may create conflicts after removing / adding items. So i used an IIdgenerator, the same that we use e.g for ContentItem.

[ns8482e]

route_todoid

[ns8482e]

route_todoid

[jtkech]

Good catch 👍

[ns8482e]

@jtkech Any other suggestions or concerns for this PR ?

[jtkech]

@ns8482e

Any other suggestions or concerns for this PR ?

LGTM but because LiquidTagHelperActivator is a sensitive array about performance, i was waiting for a feedback from @sebastienros. That said, because of this line of code we check if we already have a setter before doing extra work, so i think that there is not so much impact on the performance.