Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register DI of ShellFeaturesManager and ShellDescriptorFeaturesManager in AddExtensionServices instead of Infrastructure #10326

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

ns8482e
Copy link
Contributor

@ns8482e ns8482e commented Sep 23, 2021

Fixes #10311

/cc @jtkech @sebastienros @CrestApps

Theming can be added in ASP.NET CORE Apps as following

         services
                .AddOrchardCore()
                .AddMvc()
                .AddTheming()

@Piedone
Copy link
Member

Piedone commented Feb 16, 2022

Is this intentionally not merged yet, @jtkech?

@jtkech
Copy link
Member

jtkech commented Feb 16, 2022

No, I just think it has been forgotten

@jtkech jtkech merged commit e484e36 into OrchardCMS:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShellDescriptorManager depends on YesSql.ISession and isn't ideal when only using OrchardCore without the CMS
3 participants