Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NRE in MediaFieldIndexHandler #11066

Merged
merged 1 commit into from Jan 24, 2022
Merged

Fix NRE in MediaFieldIndexHandler #11066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Media/Indexing/MediaFieldIndexHandler.cs
View file
Open in desktop
Expand Up @@ -39,9 +39,16 @@ public async override Task BuildIndexAsync(MediaField field, BuildFieldIndexCont
{
foreach (var key in context.Keys)
{
foreach (var mediaText in field.MediaTexts)
if (field.MediaTexts != null)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, for backward compatibility, since this is a String Array it will return a NRE if nothing has been previously assigned to this field.

{
context.DocumentIndex.Set(key + MediaTextKeySuffix, mediaText, options);
foreach (var mediaText in field.MediaTexts)
{
context.DocumentIndex.Set(key + MediaTextKeySuffix, mediaText, options);
}
}
else
{
context.DocumentIndex.Set(key + MediaTextKeySuffix, "NULL", options);
}
}
}
Expand Down