Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Mirror SRI #11366

Merged
merged 1 commit into from Mar 17, 2022
Merged

Code Mirror SRI #11366

merged 1 commit into from Mar 17, 2022

Conversation

agriffard
Copy link
Member

codemirror.css and codemirror.js SRIs changed, compared to those I generated for the last PR:

https://github.com/OrchardCMS/OrchardCore/pull/11247/files#diff-596f484f166194b186319679b8d4d9ffbeb229b566217781278ba98d0d4f9f6b

.css are back to the previous one and .js to another one.

I don't really understand what has happened.
It could have been my mistake but why 2 times and with different causes?

I figured it out by testing this page: /Admin/Settings/userRegistration, whose Script Reset button does not work BTW.

@Skrypt
Copy link
Contributor

Skrypt commented Mar 17, 2022

I found another one

image

@agriffard agriffard merged commit a4ef6cb into main Mar 17, 2022
@agriffard agriffard deleted the ag/codemirrorSRI branch March 17, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants