Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #11360 Liquid IHtmlContent #11399

Merged
merged 1 commit into from Mar 29, 2022
Merged

Fixes #11360 Liquid IHtmlContent #11399

merged 1 commit into from Mar 29, 2022

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Mar 17, 2022

Fixes #11360

@Skrypt
Copy link
Contributor

Skrypt commented Mar 18, 2022

Seems like an appropriate fix. Have you tested the result to assert that it fixes the issue though? Just making sure. Else, lgtm.

@jtkech
Copy link
Member Author

jtkech commented Mar 18, 2022

Have you tested the result to assert that it fixes the issue though?

Yes by using a Message.liquid view, first I could repro then checked that it fixes the issue

@sebastienros sebastienros merged commit 137d572 into main Mar 29, 2022
@sebastienros sebastienros deleted the jtkech-patch-1 branch March 29, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@hishamco hishamco hishamco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liquid can't seem to handle IHtmlContent
4 participants
@jtkech @Skrypt @sebastienros @hishamco