Fixing html error in the admin UI (Lombiq Technologies: OCORE-87) #11425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
requested changes
Mar 23, 2022
src/OrchardCore.Modules/OrchardCore.AuditTrail/Navigation/AuditTrailSettingsAdminMenu.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenu.cshtml
Outdated
Show resolved
Hide resolved
Piedone
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Run it though the https://validator.w3.org/ validator as well, please.
src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenu.cshtml
Outdated
Show resolved
Hide resolved
Piedone
requested changes
Mar 28, 2022
|
I wasn't running it properly before. I found some mistakes, and most errors in the "UserMenu.cshtml" and "Layout. cshtml" should be fixed. I didn't find any error in the Admin.css. UserMenu:
Layout:
|
Piedone
requested changes
Mar 29, 2022
Piedone
approved these changes
Mar 30, 2022
Skrypt
reviewed
Mar 30, 2022
| @@ -65,7 +67,9 @@ | |||
| <div id="ta-left-sidebar" class="d-flex flex-column justify-content-between align-items-stretch"> | |||
| @await RenderSectionAsync("Navigation", required: false) | |||
| <div class="footer"> | |||
| <button class="leftbar-compactor" type="button" title="@T["Collapse / expand menu"]"></button> | |||
| <button type="button" class="leftbar-compactor" title="@T["Collapse / expand menu"]"> | |||
| <span>@T["Collapse / expand menu"]</span> | |||
There was a problem hiding this comment.
Next time use class="d-none"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a UI test for one of our Lombiq modules, and I came across some UI errors/warnings in the admin page.
I am attaching the validation report, and here are the rules which got validated:
HtmlValidationReport.txt