Added additional OpenId Introspection/Revocation endpoints and PKCE to the OpenID Settings and Application UI pages #11903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am to the Application settings UI. Also added introspection and revocation to the server settings UI.
…obal and application settings. Updated docs for PKCE.
kevinchalet
reviewed
Jul 4, 2022
src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ApplicationController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Views/Application/Create.cshtml
Outdated
Show resolved
Hide resolved
…dServerConfiguration.cs Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Skrypt
reviewed
Jul 5, 2022
Skrypt
reviewed
Jul 5, 2022
hishamco
requested changes
Jul 5, 2022
src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/OpenIdApplicationExtensions.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Views/Application/Create.cshtml
Outdated
Show resolved
Hide resolved
hishamco
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
From other than OpenId, everything seems good to me, @kevinchalet your approval is very important for this one
kevinchalet
approved these changes
Jul 8, 2022
src/OrchardCore.Modules/OrchardCore.OpenId/Configuration/OpenIdServerConfiguration.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Services/OpenIdServerService.cs
Outdated
Show resolved
Hide resolved
…t the introspection and revocation enpoints are enabled by default.
|
@kevinchalet No problem, glad I can help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses these issues:
Closes #10803
Closes #7138 (comment)