-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dotnet format #12235
Added dotnet format #12235
Conversation
Build failed |
Probably because it is chasing its own tail. It adds a CI |
it’s failed due to line ending in Linux. Git config takes care of line ending based on OS. However editorconfig has defined it crlf May be just validate it in windows only |
The EOL is for Git I believe. Could have worked with a warn-only message. Need to see if we could force squash and merge still. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rather guard against such changes as part of the .NET build, treating warnings as errors, not with a separate CI step. Also see #7950.
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Pleaes comment if you'd like to pick it up and remove the "stale" label. |
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
Added dotnet format verification (
--verify-no-changes
) in PR pipeline.Developer can fix the the reported errors by running
dotnet format