Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dotnet format #12235

Closed
wants to merge 5 commits into from
Closed

Added dotnet format #12235

wants to merge 5 commits into from

Conversation

ns8482e
Copy link
Contributor

@ns8482e ns8482e commented Aug 21, 2022

Added dotnet format verification (--verify-no-changes) in PR pipeline.

Developer can fix the the reported errors by running dotnet format

@ns8482e ns8482e requested a review from jtkech August 21, 2022 02:18
@MikeAlhayek
Copy link
Member

MikeAlhayek commented Aug 22, 2022

Build failed

@Skrypt
Copy link
Contributor

Skrypt commented Aug 22, 2022

Probably because it is chasing its own tail. It adds a CI dotnet format check while there are issues needed to be fixed which this PR fixes. The issues will need to be fixed in another PR before adding this dotnet format check.

@ns8482e
Copy link
Contributor Author

ns8482e commented Aug 22, 2022

Build failed

it’s failed due to line ending in Linux. Git config takes care of line ending based on OS. However editorconfig has defined it crlf

May be just validate it in windows only

@Skrypt
Copy link
Contributor

Skrypt commented Aug 22, 2022

The EOL is for Git I believe. Could have worked with a warn-only message. Need to see if we could force squash and merge still.

Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rather guard against such changes as part of the .NET build, treating warnings as errors, not with a separate CI step. Also see #7950.

Copy link

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Pleaes comment if you'd like to pick it up and remove the "stale" label.

@github-actions github-actions bot added the stale label May 13, 2024
Copy link

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

@github-actions github-actions bot closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants