Enable / disable RSS feed per list #12677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @MikeKry |
ns8482e
reviewed
Oct 22, 2022
MikeKry
reviewed
Oct 26, 2022
src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListPartFeedHandler.cs
Outdated
Show resolved
Hide resolved
|
Added one comment, otherwise it looks ok. Good work :) |
|
@sebastienros the PR is ready to merge |
sebastienros
reviewed
Nov 3, 2022
src/OrchardCore/OrchardCore.Feeds.Abstractions/Models/FeedMetadata.cs
Outdated
Show resolved
Hide resolved
|
@hishamco we made some changes during triage, let us know if you are fine with them |
|
I will check ASAP .. |
hishamco
commented
Nov 3, 2022
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartFeed.Edit.cshtml
Outdated
Show resolved
Hide resolved
hishamco
commented
Nov 3, 2022
src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListFeedEditViewModel.cs
Show resolved
Hide resolved
hishamco
commented
Nov 3, 2022
src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListPartFeedHandler.cs
Outdated
Show resolved
Hide resolved
hishamco
commented
Nov 3, 2022
src/OrchardCore.Modules/OrchardCore.Lists/Feeds/ListFeedQuery.cs
Outdated
Show resolved
Hide resolved
|
@sebastienros if you fine with above comments I will push the changes |
hishamco
commented
Nov 3, 2022
src/OrchardCore.Modules/OrchardCore.Lists/Views/ListPartFeed.Edit.cshtml
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Nov 3, 2022
hishamco
commented
Nov 4, 2022
| { | ||
| /// <summary> | ||
| /// Used to gather custom Feed properties for a content item. | ||
| /// </summary> | ||
| public class FeedMetadata | ||
| { | ||
| public bool DisableRssFeed { get; set; } |
There was a problem hiding this comment.
We come back to EnableRssFeed ;)
DisableRssFeed == false <=> EnableRssFeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12650