Fixes #12596: Sitemap Home Page Url #12729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12596
Fixes #12167
It was already intended to work through the
HomeRouteValuesAddressSchemewhen generating a link, but at some point we allowed contained items to be routable (also the Home Page) by introducing a new route value whose key isJsonPathKey.The problem was that when the Home Page is not a contained item, the
HomeRoutewas still containing aJsonPathKeyvalue, an empty string but not null. So in that case, when genarating the url theExplicitValueswas not matching theHomeRoute.So in that case the solution was to set this entry to null or just remove this entry as done here, this when we publish an item to be the new Home, and then persist the new
HomeRouteto Site Settings.