New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AddIndexProvider and AddScopedIndexProvider extensions #13060
Add AddIndexProvider and AddScopedIndexProvider extensions #13060
Conversation
return services.AddSingleton<IIndexProvider, TIndexProvider>(); | ||
} | ||
|
||
public static IServiceCollection AddScopedIndexProvider<TIndexProvider>(this IServiceCollection services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the AddIndexProvider
but not this one because naming is confusing little bit it registers IIndexProvider
as scoped service or registers IScopedIndexProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. I renamed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the API name itself not the parameter ;) let us hear the folks feedback
No description provided.