Improve Azure AD Docs (Lombiq Technologies: OCORE-112) #13063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Jan 9, 2023
| - TenantId: Provide the Directory ID value from the Azure Active Directory properties | ||
| - CallbackPath: The request path within the application's base path where the user-agent will be returned. The middleware will process this request when it arrives. | ||
| If no value is provided, setup Azure AD app to use the default path /signin-oidc. | ||
| - Display Name: The text that'll be displayed on the Orchard login screen. We recommend something like "My Company Microsoft account". |
There was a problem hiding this comment.
Can we move these in a tabular format if it's possible
There was a problem hiding this comment.
It certainly is, but I don't see how that would be nicer here (and it would be quite ugly in Markdown).
There was a problem hiding this comment.
It's there in almost if not all the settings. Not an issue
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
hishamco
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few errors and ommissions, so after figuring out what needs to be configured to make login work, I thought I'd write it down too.