Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zh-Hans-CN & zh-Hant-TW cultures in setup #13076

Merged
merged 2 commits into from Jan 26, 2023

Conversation

hishamco
Copy link
Member

No description provided.

"ar", "cs", "de", "el", "en", "es", "fa", "fr", "it", "ja", "pl", "pt-BR", "ru", "sv", "tr", "vi", "zh-CN", "zh-TW"
private string[] _supportedCultures = new string[]
{
"ar", "cs", "de", "el", "en", "es", "fa", "fr", "it", "ja", "pl", "pt-BR", "ru", "sv", "tr", "vi", "zh-Hans-CN", "zh-Hant-TW"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienros I think we should add zh-Hans & zh-Hant after your latest changes, right?

Copy link
Contributor

@Skrypt Skrypt Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be zh-Hans and zh-Hant in these values then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me & Seb planned to add zh-Hans-CN & zh-hant-TW at the beggining, then Seb changes his mind to support zh-Hans & zh-Hant ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes more sense. But then, make sure that it will pick up an actual localization folder that works. These cultures listed there are cultures that matches localization folders that we have that comes from Crowdin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes more sense

But if you look from different angle, all the specific Chinsese cultures will be fallback to their parent which is weird, I'm sure zh-Hant-TW is different tham zh-Hant-SG for instance, but the introduced why will treat them same as tranditional chinese /cc @sebastienros

Skrypt
Skrypt previously approved these changes Jan 24, 2023
@jtkech
Copy link
Member

jtkech commented Jan 25, 2023

See #11672 (comment)

@sebastienros sebastienros merged commit 8062ec7 into main Jan 26, 2023
@sebastienros sebastienros deleted the hishamco/setup-chinese-cultures branch January 26, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants