New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zh-Hans-CN & zh-Hant-TW cultures in setup #13076
Conversation
"ar", "cs", "de", "el", "en", "es", "fa", "fr", "it", "ja", "pl", "pt-BR", "ru", "sv", "tr", "vi", "zh-CN", "zh-TW" | ||
private string[] _supportedCultures = new string[] | ||
{ | ||
"ar", "cs", "de", "el", "en", "es", "fa", "fr", "it", "ja", "pl", "pt-BR", "ru", "sv", "tr", "vi", "zh-Hans-CN", "zh-Hant-TW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastienros I think we should add zh-Hans
& zh-Hant
after your latest changes, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it not be zh-Hans and zh-Hant in these values then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me & Seb planned to add zh-Hans-CN
& zh-hant-TW
at the beggining, then Seb changes his mind to support zh-Hans
& zh-Hant
;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes more sense. But then, make sure that it will pick up an actual localization folder that works. These cultures listed there are cultures that matches localization folders that we have that comes from Crowdin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes more sense
But if you look from different angle, all the specific Chinsese cultures will be fallback to their parent which is weird, I'm sure zh-Hant-TW
is different tham zh-Hant-SG
for instance, but the introduced why will treat them same as tranditional chinese /cc @sebastienros
See #11672 (comment) |
No description provided.