Don't normalize User.RoleNames

[jtkech]

As it was before.

[MikeAlhayek]

Suggested change

	if (!roleNames.Any(r => NormalizeKey(r) == normalizedRoleName))
	if (String.IsNullOrEmpty(roleName))

[jtkech]

Here we check RoleNames not RoleName

For now I just copy paste the code as it was before.

[MikeAlhayek]

@jtkech yes I understand. you don't need to check names all over again since you are doing the same check in the previous line.

The code should look like this if you want to drop ? since the GetRoleNameAsync() would return collection not nullable.

        public async Task AddToRoleAsync(IUser user, string normalizedRoleName, CancellationToken cancellationToken)
        {
            if (user == null)
            {
                throw new ArgumentNullException(nameof(user));
            }

            if (user is User u)
            {
                var roleNames = await _roleService.GetRoleNamesAsync();

                var roleName = roleNames.FirstOrDefault(name => NormalizeKey(name) == normalizedRoleName);

                if (String.IsNullOrEmpty(roleName))
                {
                    throw new InvalidOperationException($"Role {normalizedRoleName} does not exist.");
                }

                u.RoleNames.Add(roleName);
            }
        }

[jtkech]

But yes better, done

[MikeAlhayek]

Suggested change

	var roleName = roleNames?.FirstOrDefault(r => NormalizeKey(r) == normalizedRoleName);
	var roleName = roleNames.FirstOrDefault(r => NormalizeKey(r) == normalizedRoleName);

[jtkech]

Will check, for now here it is as it was before

[jtkech]

Done locally

[MikeAlhayek]

Suggested change

	var roleName = roleNames?.FirstOrDefault(r => NormalizeKey(r) == normalizedRoleName);
	var roleName = roleNames.FirstOrDefault(r => NormalizeKey(r) == normalizedRoleName);

[jtkech]

idem

[jtkech]

done

[MikeAlhayek]

Suggested change

	if (!roleNames.Any(r => NormalizeKey(r) == normalizedRoleName))
	if (String.IsNullOrEmpty(roleName))

[jtkech]

idem

[jtkech]

done

[MikeAlhayek]

I think it is safer to use RoleNames = new string[] { "Administrator" }, but up to you. Maybe just undo the change to this class completely.

[jtkech]

Here the little fix is to not set the IList RoleNames to a string array, otherwise it saves in the json document the following.

"RoleNames":{"$type":"System.String[], System.Private.CoreLib","$values":["Administrator"]}

In place of

"RoleNames":["Administrator"]

[jtkech]

Then we add a role to an empty list because the user is created just before.

[MikeAlhayek]

@jtkech I think this should be merged ASAP. I am approving this change.

[jtkech]

Okay, just waiting for unit tests

[jtkech]

Please wait, I'm testing it