Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing settings in tenant ApiController #13111

Merged
merged 4 commits into from Jan 26, 2023
Merged

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Jan 18, 2023

Fixes #13108

@hishamco
Copy link
Member Author

@MZole seems there are few other than description ;)

@hishamco
Copy link
Member Author

What about recipes & feature profiles?

@MZole
Copy link
Contributor

MZole commented Jan 18, 2023

@MZole seems there are few other than description ;)

Yes, good catch, I only noticed the description.

What about recipes & feature profiles?

I have tested them and they work as intended, they get set from the sent model.

@hishamco
Copy link
Member Author

I have tested them and they work as intended, they get set from the sent model.

Really!! I didn't see any IRecipeHarvester injected there

@MZole
Copy link
Contributor

MZole commented Jan 18, 2023

Yes, I have tested it in our project, we have a console application tester for the ApiClient which creates and sets up a tenant, and I also tested your solution for the isNewTenant with this 😃.

@hishamco
Copy link
Member Author

Seems I need to try this one ;)

…ption

# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/ApiController.cs
@hishamco hishamco merged commit 2ba0cfd into main Jan 26, 2023
@hishamco hishamco deleted the hishamco/tenant-description branch January 26, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Tenant description setting in the Tenant's ApiController
3 participants