fix error condition for custom fields #13148
Conversation
| @@ -53,6 +53,11 @@ public void Build(FieldType contentQuery, ContentTypeDefinition contentTypeDefin | |||
| continue; | |||
| } | |||
|
|
|||
| if (!(part.PartDefinition.Fields.Any(field=> contentFieldProviders.Any(fieldProvider=>fieldProvider.GetField(field)!=null)))) | |||
There was a problem hiding this comment.
This line will be more readable if you use a regular foreach loop. Also, fix the spacing
There was a problem hiding this comment.
It's not really a loop. It's a boolean expression testing that no standard field types are included in the current ContentPart.
There was a problem hiding this comment.
well, Any loop over the records. I think the LINQ expression you have is hard to read when looking at the code. You could create a new collection of all valid fields and use the collection later on.
There was a problem hiding this comment.
That would be duplicating the logic already in the fieldProvider and, IMO, it would make the process a lot more complicated that it is right now.
That being said, if the Orchard Core maintainers think it would improve the project, their welcome to create all that extra logic. This commit fixes the issue so I'm good with it as is.
#13144
#13136
When a ContentPart only contains custom fields, that GraphQL doesn't know how to use, the ContentPart is excluded.