Harvest inner recipes once #13179
Merged
Harvest inner recipes once #13179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RecipesStep.cs
A while ago, for each inner recipe we were only harvesting recipes for a given "Feature Id" being passed through the
ExecutionIdproperty of the inner recipe.Now we always harvest all recipes, so can be done once before the loop in place of doing it on each iteration (for each inner recipe).
The
ExecutionIdproperty was still used unnecessarily, here this is no longer the case, so theExecutionIdcan be removed from the inner recipe definitions.