Clean up #13202
Merged
Clean up #13202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested review from
sfmskywalker,
deanmarcussen,
kevinchalet,
Jetski5822,
carlwoodhouse and
jtkech
as code owners
hishamco
removed request for
carlwoodhouse,
Jetski5822,
sfmskywalker,
kevinchalet,
deanmarcussen and
jtkech
MikeAlhayek
approved these changes
Feb 4, 2023
src/OrchardCore.Modules/OrchardCore.Media.AmazonS3/AwsStorageOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
| Name = "Search", | ||
| Area = searchProviders.FirstOrDefault().AreaName, | ||
| Action = "Search", | ||
| Controller = "Search" } | ||
| Controller = "Search" |
There was a problem hiding this comment.
But why they made it available then ;)
There was a problem hiding this comment.
Seems hint for those who writing fast :)
There was a problem hiding this comment.
StyleCop has this rule to enforce a trailing comma in multi-line object initializers.
The advantage of having it is that changes to the code will be restricted to adding and removing lines, in contrast to adding a new line at the end of the object initializer AND adding a the comma to the line before. This makes diffs a lot more readable.
I think we should have analyzers in place for such things to avoid overhead in reviews.
UPDATE: See this SO answer for more background info on the topic.
src/OrchardCore/OrchardCore.FileStorage.AmazonS3/AwsFileStorage.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.FileStorage.AzureBlob/BlobFileStore.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Users.Core/Authentication/CacheTicketStore.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.