Fix RootNamespace #13436
Merged
Fix RootNamespace #13436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
Mar 31, 2023
jtkech
reviewed
Mar 31, 2023
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <RootNamespace>OrchardCore.Data</RootNamespace> | |||
| <RootNamespace>OrchardCore.Data.YesSql</RootNamespace> | |||
There was a problem hiding this comment.
I thought that someone might comment on this one :) but while the OC.Data.YesSql has its own project it would be better to use YesSql at the end of the namespace, but you still can use OC.Data namespace
Again if there's a type on OC.Data.YesSql project and OC.Data namespace, it might let us ask why it's not on OC.Data especially if it's not related to YesSQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.