Allows any tenant to be at the root #13958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtkech
changed the title
|
Has been tried by @devlife, see #13952 (comment) @Skrypt I let you review it when you will have time, and approve if you think that's okay. |
Skrypt
approved these changes
Jul 7, 2023
hishamco
reviewed
Jul 7, 2023
| // The 'Default' shell is first created by the infrastructure, | ||
| // so the following 'Autosetup' options need to be passed. | ||
| shellSettings.RequestUrlHost = options.RequestUrlHost; | ||
| shellSettings.RequestUrlPrefix = options.RequestUrlPrefix; |
There was a problem hiding this comment.
If it's not the default tenant how the URL prefix will be set?!!
There was a problem hiding this comment.
Just before there is a CreateTenantSettings() which is called for each tenant to pre-create them with the Autosetup options, unless for the Default tenant which is still created by the shellHost initialization on the first request.
|
Don't merge it yet. I want to have some time to test it. Need to see if we can automate some tests with this. |
|
Okay, let me know ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13952
Meaning to AutoSetup the Default tenant but with a non empty
RequestUrlPrefix. And then also allows to Autosetup a non Default tenant being at the root, meaning having a null/emptyRequestUrlPrefix.Todo: Also allow the same from the admin UI or API controller, as it was before.
Okay done by updating the
TenantValidatorbut we still check if 2 tenants (including the Default) have both the sameRequestUrlPrefixand a sharedRequestUrlHost.