Fix the Navbar menu on TheAdmin and TheTheme #14143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but the notification menu item should be before the user menu |
|
@hishamco I do not want to change the existing order. I just want to fix the existing html issue. You are welcome to submit a PR to change the order. If you are good with this PR, please approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14142
AFTER
TheTheme
TheAdmin
BEFORE
TheTheme
As you can see below the menu on TheTheme do not show up correctly. Portion of the menu is hidden.
TheAdmin
As you can see the spacing between the notification menu and the light/dark mode icon is not constant and does not look good.