IAsyncConfigureOptions #14759
Merged
IAsyncConfigureOptions #14759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
reviewed
Nov 27, 2023
There was a problem hiding this comment.
@jtkech I had similar thought as well. This is great. I'll test it out tomorrow. We should use this with every configuration class that use ISiteService. Good work
src/OrchardCore.Modules/OrchardCore.DataProtection.Azure/BlobOptionsSetup.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/IAsyncConfigureOptions.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/IAsyncOptions.cs
Show resolved
Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
MikeAlhayek
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we found a way to configure asynchronously the Azure Data Protection.
Here we provide a more global way so that it can be used in other places, this by introducing
IAsyncOptionsandIAsyncConfigureOptions<TOptions>, and a services configure helper.For example in the following,
BlobOptionswill be registered once as a singleton and configured asynchronously once byBlobOptionsSetup.ConfigureAsync()just after a tenant container is created.@MikeAlhayek If you can try this version when you will have time.