Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to add Razor HTML content to the shape as a property #14867

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Make it possible to add Razor HTML content to the shape as a property #14867

wants to merge 43 commits into from

Commits on Dec 8, 2023

  1. Add Content property when it's not defined.

    @sarahelsaig
    sarahelsaig committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    30475d2 View commit details
    Browse the repository at this point in the history

  2. Fix demo controller. 

    For some reason the original code kept crashing, saying something along the lines of IShape doesn't have "Line" method.
    @sarahelsaig
    sarahelsaig committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    299043c View commit details
    Browse the repository at this point in the history

  3. Adding demo content.

    @sarahelsaig
    sarahelsaig committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f661706 View commit details
    Browse the repository at this point in the history

  4. Document spacing.

    @sarahelsaig
    sarahelsaig committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ec33f93 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge branch 'main' into shape-tag-helper-inner-content

    @sarahelsaig
    sarahelsaig committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9a30f5c View commit details
    Browse the repository at this point in the history

  2. Rename the shape property to HtmlContent from Content to avoid confli… 

    …ct with existing special property.
    @sarahelsaig
    sarahelsaig committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b18f2f8 View commit details
    Browse the repository at this point in the history

  3. cshtml formatting.

    @sarahelsaig
    sarahelsaig committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    81a7de8 View commit details
    Browse the repository at this point in the history

  4. Fix cshtml mistake.

    @sarahelsaig
    sarahelsaig committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3cb0f91 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9380261 View commit details
    Browse the repository at this point in the history

  2. Replace bare HTML content with a <html-content> child tag helper.

    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    71f97cf View commit details
    Browse the repository at this point in the history

  3. Bug fix for html-content with embedded shape.

    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    75fb190 View commit details
    Browse the repository at this point in the history

  4. Demo multiple properties.

    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ed31344 View commit details
    Browse the repository at this point in the history

  5. Add extension points to BaseShapeTagHelper for more behavior control … 

    …in derived classes.
    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    22241d9 View commit details
    Browse the repository at this point in the history

  6. Spacing and spelling.

    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    65653e9 View commit details
    Browse the repository at this point in the history

  7. Remove duplicate GetChildContentAsync call.

    @sarahelsaig
    sarahelsaig committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f8bc3d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1731a60 View commit details
    Browse the repository at this point in the history

  2. Remove extension points.

    @sarahelsaig
    sarahelsaig committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5e8e5ca View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Adjust HtmlContentTagHelper to be more similar to other shape child t… 

    …ag helpers such as add-alternate.
    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3db27d5 View commit details
    Browse the repository at this point in the history

  2. Remove comment.

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    25c6805 View commit details
    Browse the repository at this point in the history

  3. Rename to add-property.

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    9d43867 View commit details
    Browse the repository at this point in the history

  4. Add optional value attribute to add-property.

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4ac5a17 View commit details
    Browse the repository at this point in the history

  5. rename file and class to AddPropertyTagHelper

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    35f6e20 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    8798a68 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'shape-tag-helper-inner-content' of https://github.com/s… 

    …arahelsaig/OrchardCore into shape-tag-helper-inner-content
    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    9a6ee64 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c8b383c View commit details
    Browse the repository at this point in the history

  9. Update documentation.

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3395057 View commit details
    Browse the repository at this point in the history

  10. wording

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    fd29e62 View commit details
    Browse the repository at this point in the history

  11. Use prop- in explanation.

    @sarahelsaig
    sarahelsaig committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    1b40522 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Merge branch 'main' into shape-tag-helper-inner-content

    @Piedone
    Piedone committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    eb4ebbd View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Update src/docs/reference/core/Placement/README.md 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @sarahelsaig @Piedone
    sarahelsaig and Piedone committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e3840cf View commit details
    Browse the repository at this point in the history

  2. Update src/docs/reference/core/Placement/README.md 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @sarahelsaig @Piedone
    sarahelsaig and Piedone committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d5da5fb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    84f6389 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    12afe10 View commit details
    Browse the repository at this point in the history

  5. Reference in change log.

    @sarahelsaig
    sarahelsaig committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2817473 View commit details
    Browse the repository at this point in the history

  6. Move demo code to separate action.

    @sarahelsaig
    sarahelsaig committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f3a1d01 View commit details
    Browse the repository at this point in the history

  7. fix spacing

    @sarahelsaig
    sarahelsaig committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8d6b12d View commit details
    Browse the repository at this point in the history

  8. Update src/docs/releases/2.0.0.md 

    Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
    @sarahelsaig @hishamco
    sarahelsaig and hishamco committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    499b08a View commit details
    Browse the repository at this point in the history

  9. Update src/OrchardCore.Modules/OrchardCore.Demo/Views/EmbedContentInS… 

    …hape.cshtml

Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
    @sarahelsaig @hishamco
    sarahelsaig and hishamco committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4d06f62 View commit details
    Browse the repository at this point in the history

  10. Update src/docs/reference/core/Placement/README.md 

    Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
    @sarahelsaig @hishamco
    sarahelsaig and hishamco committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f223a9e View commit details
    Browse the repository at this point in the history

  11. Update src/OrchardCore/OrchardCore.DisplayManagement/TagHelpers/AddPr… 

    …opertyTagHelper.cs

Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
    @sarahelsaig @hishamco
    sarahelsaig and hishamco committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    331c8f6 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'upstream/main' into shape-tag-helper-in… 

    …ner-content
    @sarahelsaig
    sarahelsaig committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    52a7cdc View commit details
    Browse the repository at this point in the history

  13. Update src/docs/releases/2.0.0.md 

    Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
    @sarahelsaig @hishamco
    sarahelsaig and hishamco committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    eb28a0f View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into shape-tag-helper-inner-content

    @hishamco
    hishamco committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9193498 View commit details
    Browse the repository at this point in the history