Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/error when querying nested content items with list part #14916

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix/error when querying nested content items with list part #14916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a989c7
Changed RevolveAsync on Field in ListQueryObjectType to ResolvedLocke…
ggkoning Dec 18, 2023
1665cd3
Add comment
ggkoning Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/OrchardCore.Modules/OrchardCore.Lists/GraphQL/ListQueryObjectType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using GraphQL.Types;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Localization;
using OrchardCore.Apis.GraphQL;
using OrchardCore.ContentManagement;
using OrchardCore.ContentManagement.GraphQL.Queries.Types;
using OrchardCore.ContentManagement.Records;
Expand All @@ -28,7 +29,8 @@ public ListQueryObjectType(IStringLocalizer<ListQueryObjectType> S)
.Description("the content items")
.Argument<IntGraphType, int>("first", "the first n elements (10 by default)", 10)
.Argument<IntGraphType, int>("skip", "the number of elements to skip", 0)
.ResolveAsync(async g =>
// Important to use ResolveLockedAsync to prevent concurrency error on database query, when using nested content items with List part
.ResolveLockedAsync(async g =>
{
var serviceProvider = g.RequestServices;
var session = serviceProvider.GetService<ISession>();
Expand Down