Some improvements around building common shapes #15652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Apr 3, 2024
| @@ -97,8 +98,8 @@ public async Task<IHtmlContent> ExecuteAsync(DisplayContext context) | |||
| await shapeDescriptor.DisplayingAsync.InvokeAsync((action, displayContext) => action(displayContext), displayContext, _logger); | |||
|
|
|||
| // Copy all binding sources (all templates for this shape) in order to use them as Localization scopes. | |||
| shapeMetadata.BindingSources = shapeDescriptor.BindingSources.Where(x => x != null).ToList(); | |||
| if (!shapeMetadata.BindingSources.Any()) | |||
| shapeMetadata.BindingSources = shapeDescriptor.BindingSources; | |||
There was a problem hiding this comment.
Can you check that no null values can be set as Bindingsources in any way?
There was a problem hiding this comment.
in the ShapeAlterationBuilder.cs which is why I added a null check. and if needed, we can add .Where(x => x != null) in the ShapeDescriptorIndex class instead so it is not evaluated on every call.
agriffard
changed the title
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.