Avoid null exception when href is null.

[MikeAlhayek]

Fix #15752

[Piedone]

As I explained under the issue, that property shouldn't be null, to begin with. And if it is, we should throw a proper exception, because it's an invalid state for the menu, we shouldn't hide that.

[MikeAlhayek]

As I explained under the issue, that property shouldn't be null, to begin with. And if it is, we should throw a proper exception, because it's an invalid state for the menu, we shouldn't hide that.

It won't be null if it was was added by the UI. But if you add it from other sources like migration, it could be null. The code should avoid throw an unexpected a null reference exception.

[Piedone]

Is it OK if it's null? I don't think a null Href makes sense. Why would we have such menu items?

[MikeAlhayek]

Is it OK if it's null? I don't think a null Href makes sense. Why would we have such menu items?

It is not okay. But, we can incorrectly migrate a site with a null value outside the driver logic. Maybe line 12 should read this instead

Model.Href == null || Model.Href.ToString() == "#"

this way if there is an incorrect null value, we treat it as #

[Piedone]

That would explain how it can happen at all, but the corresponding issue is about Href being null for a menu item coming from code (that I can't reproduce and am baffled about how is possible, to begin with).

Having

Model.Href == null || Model.Href.ToString() == "#"

looks good, but this wouldn't yet fix the problem in the linked issue, just hide it. We can then merge this PR but I'd wait for the issue author to confirm what the root of the problem is.

[MikeAlhayek]

looks good, but this wouldn't yet fix the problem in the linked issue, just hide it. We can then merge this PR but I'd wait for the issue author to confirm what the root of the problem is.

The root of the problem is storing incorrect value in the database. But, it is better if out code does not throw unexpected exception. So we can treat null as '#' so it does not break the app, but the menu item will not be useful.

[Piedone]

This isn't coming from the DB. Read from here: #15752 (comment)

[MikeAlhayek]

@Piedone yes we should understand how that menu item is added. But, I also think we should also take this PR

[Piedone]

That's what I also said :).

[Piedone]

Looks good, but I'd like to give Italo more chance to reply under the issue. I'll merge this on Monday otherwise.