Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile to allow successful build #15784

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix Dockerfile to allow successful build #15784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

# Except src for building
!./src/*
!Directory.Build.props

# TODO : Remove this line when Docker Buildkit works in Windows
!/.build/release/*

Expand Down
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ WORKDIR /app

# Copy and build
COPY ./src /app
RUN dotnet publish /app/OrchardCore.Cms.Web -c Release -o ./build/release --framework net8.0
COPY Directory.Build.props /

RUN dotnet publish /app/OrchardCore.Cms.Web -c Release -o ./build/release --framework net8.0 /p:RunAnalyzers=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why /p:RunAnalyzers=false? Only to not have OrchardCore.ProjectTemplates fail the build? Because I fixed that under https://github.com/OrchardCMS/OrchardCore/pull/15764/files#diff-72ab0c422f0f64ea126704874042eb9d59c62896d9045e23614c50edc58df923 (BTW please review), but otherwise, there should be no analyzer violations or any other build warnings.

Though it shouldn't matter much either way, since in this build we don't really need any further checks (that happens in the CI build already).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails since we treat warnings as errors. The docker image should not care about analyzers. As long as the code build we should be able to generate a usable image. Analyzers are for us to clean up out code and should pass before merging any core to main.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, because before #15764 we had some <TreatWarningsAsErrors>true</TreatWarningsAsErrors> in csprojs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This may be removed in your PR. But if you remove it, make sure that the build still works "docker build ." Will build it assuming you have docker desktop running

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, since we still want to disable analyzers here.


# Build runtime image
FROM mcr.microsoft.com/dotnet/aspnet:8.0-nanoserver-1809 AS build_windows
Expand Down