Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Obsolete APIs #15939

Merged
merged 5 commits into from
May 3, 2024
Merged

Remove Obsolete APIs #15939

merged 5 commits into from
May 3, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented May 1, 2024

Part of #15892

In this PR, any [Obsolete] was added prior the release of 1.8 was removed since we are releasing 2.0

Copy link
Contributor

coderabbitai bot commented May 1, 2024

Warning

Rate Limit Exceeded

@MikeAlhayek has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 38 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between d336703 and e242491.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure that I didn't miss something: did you do anything apart from removing members market obsolete, and fix the build errors?

@MikeAlhayek MikeAlhayek changed the title Remove Obsolete methods for 2.0 Remove Obsolete APIs May 2, 2024
@MikeAlhayek MikeAlhayek added this to the 2.0 milestone May 2, 2024
@MikeAlhayek MikeAlhayek requested a review from Piedone May 2, 2024 16:18
@Piedone
Copy link
Member

Piedone commented May 2, 2024

Just to make sure that I didn't miss something: did you do anything apart from removing members market obsolete, and fix the build errors?

Can you please reply?

@MikeAlhayek
Copy link
Member Author

Just to make sure that I didn't miss something: did you do anything apart from removing members market obsolete, and fix the build errors?

@Piedone sorry I missed that question. Yes I did not change anything. Just removed anything that was marked obsolete prior 1.9.

@MikeAlhayek MikeAlhayek requested a review from Piedone May 3, 2024 01:49
@Piedone Piedone merged commit 4bd2294 into main May 3, 2024
16 checks passed
@Piedone Piedone deleted the ma/remove-absolete branch May 3, 2024 12:46
@gvkries
Copy link
Contributor

gvkries commented May 7, 2024

Are you sure that removing something like RuleMigrator doesn't break upgrades from older versions?

@Piedone
Copy link
Member

Piedone commented May 7, 2024

It does break. In 2.0 we can shed obsolete code like this, if we choose to not support all 1.x to 2.0 upgrades, but instead asking people to upgrade from 1.x to 1.8 first, and then to 2.0 (which we now do, and what's a usual practice with major versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants