Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose media field attribute media text in GraphQL query #15945

Merged
merged 2 commits into from
May 2, 2024

Conversation

rpedu
Copy link
Contributor

@rpedu rpedu commented May 2, 2024

Link to the issue/enhancement is here: #15944

Fix #15944

Summary by CodeRabbit

  • New Features
    • Enhanced the media module in the GraphQL API to include a new field mediatexts, allowing retrieval of media texts with paging support.

Copy link

github-actions bot commented May 2, 2024

Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request.

If you like Orchard Core, please star our repo and join our community channels

@rpedu rpedu marked this pull request as ready for review May 2, 2024 09:57
Copy link
Contributor

coderabbitai bot commented May 2, 2024

Walkthrough

The update introduces a new GraphQL query feature in the OrchardCore Media module, allowing users to retrieve media texts (like alt texts) with pagination support. This enhancement addresses a gap in the existing functionality by making media texts accessible via GraphQL queries, enhancing data retrieval capabilities for developers.

Changes

File Path Change Summary
.../OrchardCore.Media/GraphQL/MediaFieldQueryObjectType.cs Added mediatexts field to MediaFieldQueryObjectType for querying media texts with pagination.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@rpedu
Copy link
Contributor Author

rpedu commented May 2, 2024

@dotnet-policy-service agree

@dotnet-policy-service agree

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Piedone Piedone merged commit 0168664 into OrchardCMS:main May 2, 2024
5 checks passed
Copy link

github-actions bot commented May 2, 2024

Congratulations on your first PR merge! 🎉 Thank you for your contribution! We're looking forward to welcome other contributions of yours in the future. @all-contributors please add @rpedu for code.

If you like Orchard Core, please star our repo and join our community channels

Copy link
Contributor

@github-actions[bot]

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @rpedu! 🎉

@Piedone
Copy link
Member

Piedone commented May 2, 2024

WTF. @all-contributors please add @rpedu for code.

Copy link
Contributor

@Piedone

@rpedu already contributed before to code

@Piedone
Copy link
Member

Piedone commented May 2, 2024

Ah, it did work, just the bot said it didn't :|.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose media field attribute media text in GraphQL query
2 participants