Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AzureAI Search issues #16093

Merged
merged 11 commits into from
May 19, 2024
Merged

Fix AzureAI Search issues #16093

merged 11 commits into from
May 19, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented May 18, 2024

In this PR I fix the following issues that I encountered with Azure AI

  1. The Search Index content Part and Type settings was not saving the Included flag.
  2. Ensure we save IndexName and IndexFullName to the settings document.
  3. Fix AzureAISearchIndexSettings recipe step

@Piedone
Copy link
Member

Piedone commented May 18, 2024

Why don't merge?

@MikeAlhayek
Copy link
Member Author

@Piedone because I thought of something else and did not want someone to merge it yet. Anyway, it's ready not. If you like you can review it.

@Piedone
Copy link
Member

Piedone commented May 18, 2024

In that case, you can convert it into a draft, that communicates the in-progress intent quite well.

I don't really know anything about AI search, so I'm probably not the best person to review this.

@MikeAlhayek
Copy link
Member Author

Yeah I think I am the only one that is using it :)

@MikeAlhayek MikeAlhayek merged commit 21d2a70 into main May 19, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/fix-azure-ai-docs branch May 19, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants