Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a default service to link local user accounts with external ones during the registration process #16110

Merged
merged 43 commits into from
Jun 22, 2024
Merged

Implement a default service to link local user accounts with external ones during the registration process #16110

merged 43 commits into from
Jun 22, 2024

Commits on May 20, 2024

  1. feat(Users): added default services to retrieve user to link to login… 

    … data

feat(Users): changed account controller code to use new services
feat(Users): load all services in reversed enum to ret last registered services
feat(Users): updated view code

resolve OrchardCMS#16026
    @PiemP
    PiemP committed May 20, 2024
    Configuration menu
    Copy the full SHA
    aa734f1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c387004 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. fix: avoid null excpetion in AccountController 

    fix: fixed LinkParameterValue name in ViewData
fix: added to DI context DefaultExternalLoginUserToRelateFinder
    @PiemP
    PiemP committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2ee51cd View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a12d557 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0ce3a96 View commit details
    Browse the repository at this point in the history

  2. style: name changes, docs, indent, new line 

    style: formatting comment and code
style: added last extra line
style: change var name to usrLocator
docs: reviewd comment
    @PiemP
    PiemP committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    bd01473 View commit details
    Browse the repository at this point in the history

  3. cleanup before comments

    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ed96f40 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into srvcs_acct_to_login_data

    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    dfd2dd6 View commit details
    Browse the repository at this point in the history

  5. style: from LinkParameterValue to ExternalUserIdentifier 

    Update src/OrchardCore.Modules/OrchardCore.Users/Views/Account/LinkExternalLogin.cshtml

Co-authored-by: Mike Alhayek <mike@crestapps.com>
    @PiemP @MikeAlhayek
    PiemP and MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6d74eaf View commit details
    Browse the repository at this point in the history

  6. style: from LinkParameterValue to ExternalUserIdentifier 

    Update src/OrchardCore.Modules/OrchardCore.Users/Views/Account/LinkExternalLogin.cshtml

Co-authored-by: Mike Alhayek <mike@crestapps.com>
    @PiemP @MikeAlhayek
    PiemP and MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    30188bf View commit details
    Browse the repository at this point in the history

  7. style: from LinkParameterValue to ExternalUserIdentifier 

    Update src/OrchardCore.Modules/OrchardCore.Users/Views/Account/LinkExternalLogin.cshtml

Co-authored-by: Mike Alhayek <mike@crestapps.com>
    @PiemP @MikeAlhayek
    PiemP and MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ed52a4c View commit details
    Browse the repository at this point in the history

  8. style: rename method, comment interface 

    fix: build by move service to OrchardCore.Users.Core
style: rename interface to IUserToExternalLoginProvider
style: rename method to GetIdentifierKey
style: rename service class to DefaultUserToExternalLoginProvider
style: rename ViewData object to ExternalUserIdentifier
    @PiemP
    PiemP committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4726652 View commit details
    Browse the repository at this point in the history

  9. style: improved comments

    @PiemP
    PiemP committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c8898a4 View commit details
    Browse the repository at this point in the history

  10. style: removed grammar errors in comments

    @PiemP
    PiemP committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e04b9aa View commit details
    Browse the repository at this point in the history

  11. Update src/OrchardCore.Modules/OrchardCore.Users/Views/Account/LinkEx… 

    …ternalLogin.cshtml
    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1ce6665 View commit details
    Browse the repository at this point in the history

  12. Update src/OrchardCore/OrchardCore.Users.Abstractions/Services/IUserT… 

    …oExternalLoginProvider.cs
    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    5115dd3 View commit details
    Browse the repository at this point in the history

  13. Update src/OrchardCore/OrchardCore.Users.Abstractions/Services/IUserT… 

    …oExternalLoginProvider.cs
    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    604fd35 View commit details
    Browse the repository at this point in the history

  14. Update src/OrchardCore/OrchardCore.Users.Abstractions/Services/IUserT… 

    …oExternalLoginProvider.cs
    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8179182 View commit details
    Browse the repository at this point in the history

  15. Update src/OrchardCore/OrchardCore.Users.Abstractions/Services/IUserT… 

    …oExternalLoginProvider.cs
    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f210886 View commit details
    Browse the repository at this point in the history

  16. cleanup

    @MikeAlhayek
    MikeAlhayek committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    31967ed View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    06e963f View commit details
    Browse the repository at this point in the history

  2. fix: var name in account controller

    @PiemP
    PiemP committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    010de02 View commit details
    Browse the repository at this point in the history

  3. fix: comments in IUserToExternaLoginProvider

    @PiemP
    PiemP committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c9914fe View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. updated comment in IUserToExternalLoginProvider 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @PiemP @Piedone
    PiemP and Piedone committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    12e0597 View commit details
    Browse the repository at this point in the history

  2. simplified code in DefaultUserToExternalLoginProvider 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @PiemP @Piedone
    PiemP and Piedone committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3255f3d View commit details
    Browse the repository at this point in the history

  3. updated class comment IUserToExternalLoginProvider 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @PiemP @Piedone
    PiemP and Piedone committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    a330c50 View commit details
    Browse the repository at this point in the history

  4. style: code to new line in ExternalLoginInfoExtensions 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @PiemP @Piedone
    PiemP and Piedone committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7e50a95 View commit details
    Browse the repository at this point in the history

  5. docs: updated comment in the AccountController about order 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @PiemP @Piedone
    PiemP and Piedone committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    139ca99 View commit details
    Browse the repository at this point in the history

  6. style: brackets on a new line in AccountController 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @PiemP @Piedone
    PiemP and Piedone committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c28fbca View commit details
    Browse the repository at this point in the history

  7. style(Users.Abstractions): change name to interface 

    feat(Users.Abstractions): remove GetIdentifierKey
style(Users.Core): change name to default service
style(Users): change name to mappers prop and local var
    @PiemP
    PiemP committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c3f4bbe View commit details
    Browse the repository at this point in the history

  8. style: from GetUserAsync to FindByLoginAsync 

    styl: updated text in razor page
    @PiemP
    PiemP committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    5fd181a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'main' into srvcs_acct_to_login_data

    @PiemP
    PiemP committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ec6a034 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into srvcs_acct_to_login_data

    @PiemP
    PiemP committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    63e26ca View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. fix: removed IExternalLoginMapper 

    fix: removed DefaultExternalLoginMapper
fix: restored UsersServiceCollectionExtensions
fix: implemente check of RequireUniqueEmail in AccountController
    @PiemP
    PiemP committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    5c378b8 View commit details
    Browse the repository at this point in the history

  2. fix: improve if declaration 

    fix: restored check of the email value
    @PiemP
    PiemP committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    f2faf17 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    a0ce348 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    807ca2d View commit details
    Browse the repository at this point in the history

  2. Update AccountController.cs

    @MikeAlhayek
    MikeAlhayek committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    da86ae6 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'main' into srvcs_acct_to_login_data

    @PiemP
    PiemP committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6459e5d View commit details
    Browse the repository at this point in the history

  2. Update src/OrchardCore.Modules/OrchardCore.Users/Controllers/AccountC… 

    …ontroller.cs

Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
    @PiemP @hishamco
    PiemP and hishamco committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d3e1010 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into srvcs_acct_to_login… 

    …_data
    @PiemP
    PiemP committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3bfcd28 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'main' into srvcs_acct_to_login_data

    @hishamco
    hishamco committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a6ec2b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Merge branch 'main' into srvcs_acct_to_login_data

    @hishamco
    hishamco committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    7be7530 View commit details
    Browse the repository at this point in the history