Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments to clarify that an absolute path does not work for OrchardCore_Media__AssetsPaths #16293

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

rjpowers10
Copy link
Contributor

Fixes #16263

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait for the triage of the issue on Thursday to see if updating the docs is indeed the best next step.

@sebastienros sebastienros enabled auto-merge (squash) June 13, 2024 17:19
@sebastienros
Copy link
Member

Thanks, we updated the suggested sentence to remove the "must" work which was confusing.

@sebastienros sebastienros merged commit 45d3fe6 into OrchardCMS:main Jun 13, 2024
6 checks passed
@sebastienros
Copy link
Member

@rjpowers10 we just merged your PR and are having a discussion about this action. Would you have preferred us to comment on your changes and let you review them or do you prefer what we did and just went on with merging the changes we did directly to prevent back and forth?

@rjpowers10 rjpowers10 deleted the media-assets branch June 13, 2024 17:43
@rjpowers10
Copy link
Contributor Author

@sebastienros with a simple docs change like this I think it's fine to just make the change directly. No need to complicate things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrchardCore_Media__AssetsPaths says it supports absolute paths but doesn't
4 participants